add --unstaged option to view only unstaged files/hunks#521
Open
githendrik wants to merge 1 commit intobacknotprop:mainfrom
Open
add --unstaged option to view only unstaged files/hunks#521githendrik wants to merge 1 commit intobacknotprop:mainfrom
githendrik wants to merge 1 commit intobacknotprop:mainfrom
Conversation
backnotprop
reviewed
Apr 8, 2026
| } else { | ||
| // --- Local Review Mode --- | ||
| gitContext = await getVcsContext(); | ||
| initialDiffType = gitContext.vcsType === "p4" ? "p4-default" : "uncommitted"; |
Owner
There was a problem hiding this comment.
We have P4 users. I need to make sure this doesn't break for them.
Author
There was a problem hiding this comment.
Oh, okay. I wasn't aware of this case. Do you need me to change something? Just let me know.
Owner
There was a problem hiding this comment.
caveat, i havent fully reviewed...
deleted: gitContext.vcsType === "p4" ? "p4-default"
You might still need a ternary path to make this assignment is my concern.
I can validate later today and trace myself, and if I see a fix, I'll fix it. Otherwise, I think you just need to have a bit more verbose ternary that includes your new option but also the P4 default if that's set as vcsType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: #287
My personal flow is to stage hunks that I approved in previous steps. This flag allows me to view only the most recent changes.